On Sat, Sep 20, 2014 at 02:12:43PM +0200, Wolfram Sang wrote:
> Hi,
>
> thanks for the submission.
>
> On Mon, Aug 25, 2014 at 01:51:22PM +0200, Anders Berg wrote:
> > Add I2C bus driver for the controller found in the LSI Axxia family SoCs.
> > The
> > driver implements 10-bit addressing and SMBus transfer modes via emulation
> > (including SMBus block data read).
> >
> > Signed-off-by: Anders Berg <anders.b...@avagotech.com>
>
> Looks pretty good already. Still, some comments:
>
> > +config I2C_AXXIA
> > + tristate "Axxia I2C controller"
> > + depends on ARCH_AXXIA
> > + help
> > + Say yes if you want to support the I2C bus on Axxia platforms.
> > +
> > + If you don't know, say Y.
>
> I'd say skip this sentence and consider 'default y' if it is really
> needed on this platform.
Still better:
depends on ARCH_AXXIA || COMPILE_TEST
default ARCH_AXXIA
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
