On Thu, May 28, 2015 at 06:33:40PM +0530, Vaibhav Hiremath wrote: > In order to avoid "spurious irq" caused by CP polling mode, > enable irq at the entry of i2c_pxa_xfer() fn and disable it > again before exit.
NAK. It's really not nice for drivers to disable a potentially shared interrupt. If the interrupt is shared, you disable the interrupt for other users of that interrupt as well. See: commit c66dc529194be374556d166ee7ddb84a7d1d302b Author: Sebastian Andrzej Siewior <[email protected]> Date: Wed Feb 23 12:38:18 2011 +0100 i2c-pxa2xx: add support for shared IRQ handler Sodaville has three of them on a single IRQ. IRQF_DISABLED is removed because it is a NOP allready and scheduled for removal. Signed-off-by: Sebastian Andrzej Siewior <[email protected]> Signed-off-by: Dirk Brandewie <[email protected]> Signed-off-by: Ben Dooks <[email protected]> So you're breaking Sodaville. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
