On 27/07/15 12:47, Sifan Naeem wrote:
> Using % can be slow depending on the architecture.
>
> Using DIV_ROUND_UP is nicer and more efficient way to do it.
>
> Fixes: 27bce4 ("i2c: img-scb: Add Imagination Technologies I2C SCB driver")
> Signed-off-by: Sifan Naeem <sifan.na...@imgtec.com>
> Cc: Stable kernel (v3.19+) <sta...@vger.kernel.org>Acked-by: James Hogan <james.ho...@imgtec.com> Cheers James > --- > drivers/i2c/busses/i2c-img-scb.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-img-scb.c > b/drivers/i2c/busses/i2c-img-scb.c > index 0368d91..b4f59e1 100644 > --- a/drivers/i2c/busses/i2c-img-scb.c > +++ b/drivers/i2c/busses/i2c-img-scb.c > @@ -1179,9 +1179,7 @@ static int img_i2c_init(struct img_i2c *i2c) > int_bitrate++; > > /* Setup TCKH value */ > - tckh = timing.tckh / clk_period; > - if (timing.tckh % clk_period) > - tckh++; > + tckh = DIV_ROUND_UP(timing.tckh, clk_period); > > if (tckh > 0) > data = tckh - 1; > @@ -1201,9 +1199,7 @@ static int img_i2c_init(struct img_i2c *i2c) > img_i2c_writel(i2c, SCB_TIME_TCKL_REG, data); > > /* Setup TSDH value */ > - tsdh = timing.tsdh / clk_period; > - if (timing.tsdh % clk_period) > - tsdh++; > + tsdh = DIV_ROUND_UP(timing.tsdh, clk_period); > > if (tsdh > 1) > data = tsdh - 1; >
signature.asc
Description: OpenPGP digital signature
