Hi Shubhrajyoti, On Fri, Jul 31, 2015 at 3:55 PM Shubhrajyoti Datta <[email protected]> wrote: > > - offlist > On Fri, Jul 31, 2015 at 5:30 PM, Robert ABEL > <[email protected]> wrote: > > > > This patch series completely reworks Xilinx' XIIC driver. Short summary: > > Driver didn't work for me and I don't know how it could ever have worked > > for anybody. > > So I rewrote it in big parts and now it works for me™. > > > > Are you reporting a regression because of the below patches? > Or it never worked for you?
The XIIC driver never worked for me. The mainline version before your patches would enter BNB interrupt immediately. The linux-xlnx version dereferenced a null pointer, because the IRS modified i2c->tx_msg/i2c->rx_msg while the initial messages were copied to the TX FIFO. I think both behaviors might have been due to the TX FIFO running empty while not all messages were copied, because xiic was pre-empted. Or maybe something was wrong with the I²C SDA/SCL lines. Either way, code did not account for any errors, any preemption, so I'm unsure how the xiic driver works for anybody else. Regards Robert -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
