On Wed, Oct 21, 2015 at 06:56:44PM -0700, Florian Fainelli wrote: > Le 20/10/2015 19:36, Jaedon Shin a écrit : > > Add the necessary parenthesis for NOACK condition. > > > > Signed-off-by: Jaedon Shin <jaedon.s...@gmail.com> > > Acked-by: Florian Fainelli <f.faine...@gmail.com>
I wouldn't call them necessary?
>
> > ---
> > drivers/i2c/busses/i2c-brcmstb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-brcmstb.c
> > b/drivers/i2c/busses/i2c-brcmstb.c
> > index 6b8bbf99880d..2d7d155029dc 100644
> > --- a/drivers/i2c/busses/i2c-brcmstb.c
> > +++ b/drivers/i2c/busses/i2c-brcmstb.c
> > @@ -305,7 +305,7 @@ static int brcmstb_send_i2c_cmd(struct brcmstb_i2c_dev
> > *dev,
> > }
> >
> > if ((CMD_RD || CMD_WR) &&
> > - bsc_readl(dev, iic_enable) & BSC_IIC_EN_NOACK_MASK) {
> > + (bsc_readl(dev, iic_enable) & BSC_IIC_EN_NOACK_MASK)) {
> > rc = -EREMOTEIO;
> > dev_dbg(dev->device, "controller received NOACK intr for %s\n",
> > cmd_string[cmd]);
> >
>
>
> --
> Florian
signature.asc
Description: Digital signature
