On Fri, 28 Jan 2005 20:11:37 +0100, Bartlomiej Zolnierkiewicz wrote: >On Fri, 28 Jan 2005 12:16:01 -0600, Doug Maxey <[EMAIL PROTECTED]> wrote: > >We have too many config options already. > >Behavior should be simple: >* no cache flushes - wcache off by default >* cache flushes - wcache on by default >* inform user about the wcache status >* allow changing of wcache by user
My interpretation of what you are saying here is the selection of "cache flush" drives the setting of wcache. Are you saying that "barrier=off" on the boot line the currently (only and will remain) supported method controlling flushes? AFAICS, "barrier=off" just tells the FS (only ext2 and reiser) to not flush writes. I may be misunderstanding how that controls the behavior of the drive at the ll_blk layer. Is that what you want to see a patch to, pick this out of the FS? >> >> 1) move the cache_write code to ide-io, where it will be callable from >> kernels built without ide-disk. > >I've already pointed this out - this is not needed, you should add >check similar to this for 'xfer_set'. Another reason not to do this >is that write_cache() uses REQ_DRIVE_TASKFILE internally. Is taskfile going away? > >> 2) allow the drive to define the default setting of the cache when >> BLK_DEV_HDWC is set. >> >> 3) correctly handle the change of write cache setting from hdparm. >> This means that the call also changes the blk_queue_ordered() >> visible variable. > >I've asked you many times to separate this two changes. >No luck so far. > Split patch does not count? :) - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
