Below find a patch which gets the read verify command working. Note that in order to get this 100% working one also needs to apply Albert Lee's patch:
http://article.gmane.org/gmane.linux.ide/2798
to libata* before or after this. I've stripped out his portion of the changes because I can't sign off on his work.
This work was verified using a SATA bus analyzer and the sg_verify utility which sends VERIFY_10. Should libata support VERIFY_12?
Unless there is some major application which needs _12 variants, I would prefer to avoid implementing them.
I want libata-scsi.c to be compatible with the upcoming T10 "SAT" specification, but I also wish to avoid translations which are rarely used (keeps the code small).
===== drivers/scsi/libata-scsi.c 1.68 vs edited ===== --- 1.68/drivers/scsi/libata-scsi.c 2004-12-29 02:35:53 -05:00 +++ edited/drivers/scsi/libata-scsi.c 2005-02-01 19:26:55 -05:00 @@ -741,13 +741,18 @@ }
if (lba48) { + tf->command = ATA_CMD_VERIFY_EXT; + tf->hob_nsect = (n_sect >> 8) & 0xff;
tf->hob_lbah = (sect >> 40) & 0xff; tf->hob_lbam = (sect >> 32) & 0xff; tf->hob_lbal = (sect >> 24) & 0xff; - } else + } else { + tf->command = ATA_CMD_VERIFY; + tf->device |= (sect >> 24) & 0xf; + }
tf->nsect = n_sect & 0xff;
===== include/linux/ata.h 1.20 vs edited ===== --- 1.20/include/linux/ata.h 2004-11-14 03:21:22 -05:00 +++ edited/include/linux/ata.h 2005-02-01 16:28:09 -05:00 @@ -123,6 +123,9 @@ ATA_CMD_PIO_WRITE_EXT = 0x34, ATA_CMD_SET_FEATURES = 0xEF, ATA_CMD_PACKET = 0xA0, + ATA_CMD_VERIFY = 0x40, + ATA_CMD_VERIFY_EXT = 0x42,
Your patch looks good, and I tried to apply it, but apparently your mailer turned all tabs into spaces. Can you resend?
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
