Brett Russ wrote:
I coded this because ata_pass_thru_cc() (in the dev branch) and other functions call tf_read() which is supported for most except ahci. I've been unable to test because I'm leaving on vacation and am in a last minute rush but wanted to get this out there for comments.
Signed-off-by: Brett Russ <[EMAIL PROTECTED]>
I checked the attached patch into a local repository, but haven't yet merged it into libata-dev-2.6, or tested it.
The reason I didn't just use ata_tf_from_fis() was because I didn't think it was valid to overload tf->command with status and tf->feature with error. It was commented as a host->device FIS translation, where those fields would line up with the properly named tf fields.
As long as the overload is fine then this is certainly simpler than my patch.
BR
<snip>
+static void ahci_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+{
+ struct ahci_port_priv *pp = ap->private_data;
+ u8 *d2h_fis = pp->rx_fis + RX_FIS_D2H_REG;
+
+ ata_tf_from_fis(d2h_fis, tf);
}
static void ahci_fill_sg(struct ata_queued_cmd *qc)
- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
