On Sun, May 13, 2007 at 02:57:44PM +0200, Tejun Heo wrote:
> Jeff Garzik wrote:
> > Tejun Heo wrote:
> >> + if (class == ATA_DEV_ATA)
> >> + class = ATA_DEV_ATAPI;
> >> + else
> >> + class = ATA_DEV_ATA;
> >
> >
> > the 'else' branch is obviously redundant
>
> Why? We can also fallback from ATAPI to ATA.
Then did you mean to write..
+ if (class == ATA_DEV_ATA)
+ class = ATA_DEV_ATAPI;
+ else if (class == ATA_DEV_ATAPI)
+ class = ATA_DEV_ATA;
?
Otherwise, as Jeff mentions, you're doing a redundant assignment
in the else branch.
Dave
--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
