Albert Lee wrote:
> With the previous changes made to tf_load(), ap->last_ctl is now unused. 
> Remove it.
> 
> (The purpose of ap->last_ctl is to cache the last status of nIEN bit
> and hopefully avoid writing the Control register unnecessarily.
> However, the libata polling code always call irq_on() in ata_hsm_qc_complete()
> and such mechanism isn't much utilized.)
> 
> Signed-off-by: Albert Lee <[EMAIL PROTECTED]>

Ack 6-7.  Thanks for cleaning irq on/off up.  Things should have been
done this way from the beginning.  Also, I think removing last_ctl
caching (or whatever is left of it) should be okay.  Only polling PIO
path is affected and one or two more ioport accesses won't make any
meaningful difference anyway.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to