Alan Cox wrote:
On Wed, 8 Aug 2007 15:20:57 -0500
David Milburn <[EMAIL PROTECTED]> wrote:

Support the use of '*' in model_num and model_rev entries
in ata_device_blacklist[].

CC: [EMAIL PROTECTED]
Signed-off-by: David Milburn <[EMAIL PROTECTED]>

Suggestion: Pull the match function out of line so you don't have two
copies of it and can remove all the wacky ? operators

something like this ? (untested)

        strpatterncmp(const char *name, const char *patt)
        {
                const char *p = strchr(patt, '*');
                if (p == NULL)
                        p = patt + strlen(patt);
                return strncmp(name, patt, p-patt);
        }

Seems quite sane to me...

And I support the addition of wildcard operators; that should make maintenance a bit easier.


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to