On Sunday 19 August 2007, Sergei Shtylyov wrote: > The Marvell bridge chips used on HighPoint SATA cards do not seem to support > the UltraDMA modes 1, 2, and 3 as well as any MWDMA modes, so the driver needs > to account for this in the udma_filter() method. In order to achieve that, do > the following changes: > > - install the method for all chips, not only HPT36x/370 and impove the code > formatting by killing the extra tabs while at it;
s/impove/improve/ > - add to the end of the 'switch' statement in the method cases for HPT372[AN] > and HPT374 chips upon which the known SATA cards are based; > > - use hwif->ultra_mask as a default mask for the ide_dma_filter() method to > behave correctly; > > - move the HPT370[A] cases below the HPT36x case for consistency. > > While at it, replace the explicit UltraDMA mode masks with ATA_UDMA* constants > all over the driver... > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> applied > --- > This is against the current Linus tree and unfortunately I was able to only > compile test it since that tree gives MODPOST warning and dies early on > bootup. Is this still case? Not an IDE problem but definitely needs fixing especially given that we are already in -rc3... > Will hopefully finish with the patch series next weekend... - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html