> >>+           /* udmatim Register */
> >>+           palm_bk3710_base->config.udmatim &= 0xFFF0;
> >>+           palm_bk3710_base->config.udmatim |= level;
> 
> > Direct memory access to I/O space - should be using read/write functions
> 
>     Sigh, I was anticipationg that somebody would say that... :-)

Well yes - its not very nice code and it isn't really upstream to scratch.

>     Why?  ATA/PI says in the note to the table "Register transfer to/from 
> device":
> 
> 5 Mode shall be selected no higher than the *highest* mode supported by the 
> *slowest* device.

You are correct, ignore that. You don't touch the timing for the other
device.

>     It won't -- we can *not* call ide_setup_dma() which fills them out as 
> this 
> is not a PCI chip.

Gak.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to