Re: [PATCH] ata: fix sparse warning in libata.h

[Jeff Garzik]

Harvey Harrison wrote:

Avoids lots of these, also is more readable.
include/linux/libata.h:1210:13: warning: potentially expensive pointer 
subtraction

Change the subtraction to addition on the other side of the comparison.

Thanks to Christer Weinigel for the suggestion.

Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
 include/linux/libata.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/libata.h b/include/linux/libata.h
index bc5a8d0..a6243bb 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1207,7 +1207,7 @@ static inline struct ata_link *ata_port_next_link(struct 
ata_link *link)
                return ap->pmp_link;
        }

- if (++link - ap->pmp_link < ap->nr_pmp_links)

+       if (++link < ap->nr_pmp_links + ap->pmp_link)
                return link;

applied


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html