On Tue, 13 Nov 2001, Rein Klazes wrote:
> On Tue, 13 Nov 2001 00:04:19 +0200 (IST), you wrote:
>
>
> > +#else /* PPTP_BEZEQ_ISRAEL is defined */
> > + {
> > + PPTP_HEADER_CTRL(PPTP_OUT_CALL_RQST),
> > + 0, /* hton16(call->callid) */
> > + 0, /* hton16(call->sernum) */
>
> I don't understand why you need this: call->callid and call->sernum
> *are* zero for the first and only connection pptp_ctrl can make.
This is done to bypass the bug in Orckit ATUR3 ADSL modem. It is indeed
non complient with the rfc .
>
>
> > + hton32(PPTP_BPS_MIN), hton32(PPTP_BPS_MAX),
> > + hton32(PPTP_BEARER_DIGITAL), hton32(PPTP_FRAME_ANY),
> > + hton16(PPTP_WINDOW), 0, hton16(PPTP_HOSTNAME_LEN),0, PPTP_HOSTNAME, {0}
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> If I'm not mistaken you are filling the "phonenumber" field here. This
> can be specified on the command line with the option "--phonenumber".
> Perhaps some other fields that you require to be changed may be
> specified this way as well?
>
> > + };
> > +#endif
> >
> > /* fill in the phone number if it was specified */
> > if( phonenr ){
>
> which is done here.
>
>
> > @@ -473,6 +485,22 @@
> > }
> > }
> >
> > +static void
> > +pptp_set_link(PPTP_CONN* conn, int peer_call_id)
> > +{
> > + struct pptp_set_link_info packet = {
> > + PPTP_HEADER_CTRL(PPTP_SET_LINK_INFO),
> > + hton16(peer_call_id),
> > + 0,
> > + 0xffffffff,
> > + 0xffffffff};
> > +
> > + if (pptp_send_ctrl_packet(conn, &packet, sizeof(packet))) {
> > + log("pptp_set_link() packet sending succesfull");
> > + pptp_reset_timer();
> > + }
> > +}
> >
> > @@ -650,6 +691,7 @@
> > call->peer_call_id = ntoh16(packet->call_id);
> > call->speed = ntoh32(packet->speed);
> > pptp_reset_timer();
> > + pptp_set_link(conn, call->peer_call_id);
> > if (call->callback!=NULL) call->callback(conn, call, CALL_OPEN_DONE);
> > log("Outgoing call established (call ID %u, peer's call ID %u).\n",
> > call->call_id, call->peer_call_id);
>
> Strange for the set-link-info message to be sent at a point in time
> when pppd hasn't even been started creating one yet. The pptp server
> that requires this, must be really broken.
This is the way Windows clients behave. We could recheck if it is realy
needed (again, was added to support Orckit ATUR3 modem).
Dani
>
> Rein.
> --
> Rein Klazes
> [EMAIL PROTECTED]
>
> =================================================================
> To unsubscribe, send mail to [EMAIL PROTECTED] with
> the word "unsubscribe" in the message body, e.g., run the command
> echo unsubscribe | mail [EMAIL PROTECTED]
>
=================================================================
To unsubscribe, send mail to [EMAIL PROTECTED] with
the word "unsubscribe" in the message body, e.g., run the command
echo unsubscribe | mail [EMAIL PROTECTED]
