On 2/16/07, johann deneux <[EMAIL PROTECTED]> wrote:
On 2/15/07, Anssi Hannula <[EMAIL PROTECTED]> wrote: > Dmitry Torokhov wrote: > > On 2/15/07, STenyaK (Bruno Gonzalez) <[EMAIL PROTECTED]> wrote: > >> Sorry for not providing a proper patch, could you please also add > >> {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel > >> to the list? I tested it here and that wheel is also working. > >> > > > > OK. > > > > Hmm.. Shouldn't an entry also be added to the devices[] list in > hid-lgff.c for these devices? (and it seems one device is already > missing from there in the current kernel). > > I'm not able to check right now, but I think some earlier kernels may > have defaulted to ff_joystick if no entry is present in devices[], hence > these devices working for some without the entry. > (so the alternative is to restore that behaviour)Yes, defaulting to joystick was the way it was when I wrote hid-lgff.c, and I guess Valentin made his original patch on a kernel where defaulting was still there. I'll send a separate mail with the patch adding the devices there too, but I personally think defaulting was nice. Was there a reason behind the removal?
Simple oversight. I think we should restore defaulting. -- Dmitry
