Hi Dmitry,

On 3/18/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
Hi Johann,

On Saturday 17 March 2007 17:50, johann deneux wrote:
> A note about that patch: Apparently Anders Fugmann submitted a patch to use
> usb_kill_urb to linux-usb-devel for version 2.6.10.
> I don't know if this patch got lost, or if it was rejected.

Since every other USB dirver uses usb_kill_urb it loosk like the patch was
just missed...

>
> On 3/17/07, johann deneux <[EMAIL PROTECTED]> wrote:
> >
> > commit 0ba8785483c2ee7f56e8f242e000f6cd17a7da40
> > Author: Johann Deneux <[EMAIL PROTECTED]>
> > Date:   Sat Mar 17 22:23:44 2007 +0100
> >
> >     iforce: Use usb_kill_urb instead of usb_unlink_urb.
> >
> >     Using usb_unlink_urb can cause iforce_open to fail when called soon
> > after iforce_release.
> >     Also updated my email address and replaced calls to printk() by dbg(),
> > warn(), info(), err()...
> >

Since there seems a lot of implementations of r warn(), err(), etc what kind
of output would iforce produce?


It uses the implementation from include/linux/usb.h. The output from
the module should be approximately the same as before, except for
debug messages which were previously inconditionally produced, and are
now produced only when macro DEBUG is defined and non-zero.
Macros warn(), dbg()... in usb.h use printk KERN_WARNING, KERN_DEBUG...

--
Johann

Reply via email to