On 9/20/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote:
> + if (jornada_ssp_inout(GETTOUCHSAMPLES == TXDUMMY)) {
Are you sure? Looks like paren is pisplaced.
> +
> + ret = request_irq(IRQ_GPIO9,
> + jornada720_ts_interrupt,
> + IRQF_DISABLED | IRQF_TRIGGER_RISING,
> + "HP7XX Touchscreen driver", jornada_ts);
> + if (ret) {
> + printk(KERN_INFO "HP7XX TS : Unable to aquire irq!\n");
> + goto failed2;
> + }
> +
> + if (input_register_device(input_dev))
> + goto failed2;
You will leak IRQ_GPIO9 if input_register_device fails.
Please do not forget adding Signed-off-by: to all of your patches so I
don;t have to hunt for them through old e-mails. Thanks!
--
Dmitry
