On 10/16/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > On 10/16/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > > On 10/15/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > > > > > > > Completion is just not a good abstraction here... Please use work > > > > abstraction and possibly a separate workqueue. > > > > > > Yes, I agree with you now, although I have a little concern about the > > > possibility of big delay introduced by workqueue. > > > > > > > Having a separate workqueue should isolate the driver from users > > hogging keventd. Otherwise the speed should be pretty much the same as > > with a kthread. > > > > Does this driver need the create a new kthread instead of keventd? > I think keventd might be sufficient for this driver. >
No it does not have to start a new workqueue. I'd start with keventd and only implement a separate workqueue later if I saw the driver being starved by other keventd users. -- Dmitry
