Dmitry Torokhov wrote:
On 10/29/07, Jiri Kosina <[EMAIL PROTECTED]> wrote:
On Mon, 29 Oct 2007, Dirk Hohndel wrote:
[INPUT] hidinput_connect incorrectly ignored return value from
input_register_device
Signed-off-by: Dirk Hohndel <[EMAIL PROTECTED]>
Will apply
Please don't - the fix is completely broken for multi-input devices -
if 2nd device fails to register we bail out of hidinput_connect and
thus never set HID_CLAIMED_INPUT bit. So when we disconnect device we
never call hidinput_disconnect and who knows what will happen after
that.
hidinput_connect() should properly unwind already registered devices
after failure.
Then the existing code to handle hidinput and input_dev allocation
failure probably also wants fixing... Dirk's patch was largely
following the same logic.
Jeff
