On Sun, 2008-04-06 at 17:32 -0700, Kristoffer Ericson wrote: > On Thu, 3 Apr 2008 16:30:05 -0400 > Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > On Fri, Mar 21, 2008 at 10:43:14PM +0000, Richard Purdie wrote: > > > Later on in the code, BTN_TOUCH should do that same job but that isn't > > > looked for in the initial check_fd() code. tslib can be easily fixed to > > > address that issue and if nobody else writes a patch I'll aim to do so > > > although it might not be for a few days. > > > > > > Having said that I don't see why exporting ABS_PRESSURE of 0 and 1 isn't > > > a valid thing to do, they are pressure readings, just of a rather > > > limited range! > > > > > > > Because it does not convey any new data (BTN_TOUCH already indicates that > > the screen is being touched) and so the kernel and userspace have to spin > > wheels passing and processing/discarding useless events. > > > > Well, I agree with you on that. Unless Richard has any objections we should > email the maintainter of tslib and ask him to change that. > What you say Richard?
I don't really care whether a driver uses BTN_TOUCH or ABS_PRESSURE or both, tslib should handle all those combinations equally well. I've been meaning to write a patch, I just haven't found the time yet :(. By all means email Chris but I think he'll probably want a patch. Cheers, Richard
