Carlos Corbacho wrote:
Two minor nitpicks.
Hi Carlos,
thanks for your feedback. I just updated the patch, and submitted a new
version..
/alfred
On Tuesday 05 February 2008 21:39:30 Alfred E. Heggestad wrote:
+/*
+ * drivers/input/misc/cm109.c
Don't put the filename in the source file - this is now generally frowned
upon. Instead, replace that with a title/ short description for the driver.
e.g. Move this line up instead to the top, rather than burying it under the
copyright notice:
Driver for the VoIP USB phones with CM109 chipsets.
+ * History:
+ * 20080205 alfredh Upgrade to 2.6.24
+ * 20070829 alfredh Added keymap for Genius G-talk (thanks Shaun)
+ * 20070826 alfredh 2.6.22.5, added to blacklist in hid-quirks.c
+ * 20070626 alfredh 2.6.22-rc6, linux-input peer review
+ * 20070616 alfredh Adapt for kernel 2.6.22-rc4
+ * 20070615 alfredh Change GFP_KERNEL -> GFP_ATOMIC
+ * 20070610 alfredh Buzzer through input SND_TONE/SND_BELL
+ * 20070227 alfredh Draft version with keyboard scan and buzzer
ChangeLog's/ history should go in the commit message, not the code. It's the
job of the revision control system to maintain the history of the code, not
the codes job.
-Carlos
-
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
