On Wednesday, July 25, 2012 12:43 AM, Daniel Mack wrote: > On 24.07.2012 21:45, H Hartley Sweeten wrote: >> You might want to put this patch first before adding the DT binding >> stuff. >> >> You also might consider using gpio_request_one() or even the >> devm_* version, instead of doing the gpio_request() followed >> by the gpio_direction_input(). >> >> Actually, if you convert the probe to use the managed resource >> devm_* stuff it would really cleanup the error path and the remove. > > Yes, you're right. Thanks for the hint. New version coming up. Does your > Reviewed-by: still apply?
As pointed out by Dmitry, the devm_* stuff will not work with this driver. Please update the patch to just use the gpio_request_one() and I'll review it again. Sorry about that. Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
