On Wed, 21 Nov 2012, Sachin Kamat wrote: > Silences the following smatch warning: > drivers/hid/usbhid/hiddev.c:897 hiddev_connect() warn: > returning -1 instead of -ENOMEM is sloppy > > Signed-off-by: Sachin Kamat <[email protected]> > --- > drivers/hid/usbhid/hiddev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c > index 14599e2..50e2ab8 100644 > --- a/drivers/hid/usbhid/hiddev.c > +++ b/drivers/hid/usbhid/hiddev.c > @@ -894,7 +894,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int > force) > } > > if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL))) > - return -1; > + return -ENOMEM; > > init_waitqueue_head(&hiddev->wait); > INIT_LIST_HEAD(&hiddev->list);
Well, this would make sense only if the callers would be actualling doing something useful with that return value. But the only check we are performing at callsites is non-zero test ... Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
