Hi Guenter, On Sat, Jan 04, 2014 at 09:35:33AM -0800, Guenter Roeck wrote: > On 12/31/2013 08:20 AM, Hans de Goede wrote: > >The sun4i resisitive touchscreen controller also comes with a built-in > >temperature sensor. This commit adds support for it. > > > >This commit also introduces a new "ts-attached" device-tree property, > >when this is not set, the input part of the driver won't register. This way > >the internal temperature sensor can be used to measure the SoC temperature > >independent of there actually being a touchscreen attached to the controller. > > > >Signed-off-by: Hans de Goede <hdego...@redhat.com> > > Couple of minor comments below, though no need to resubmit unless someone > else has comments. > > Reviewed-by: Guenter Roeck <li...@roeck-us.net> > > >--- > > .../bindings/input/touchscreen/sun4i.txt | 5 + > > drivers/input/touchscreen/sun4i-ts.c | 140 > > ++++++++++++++++----- > > 2 files changed, 114 insertions(+), 31 deletions(-) > > > >diff --git a/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt > >b/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt > >index e45927e..6bac67b 100644 > >--- a/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt > >+++ b/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt > >@@ -6,10 +6,15 @@ Required properties: > > - reg: mmio address range of the chip > > - interrupts: interrupt to which the chip is connected > > > >+Optional properties: > >+ - allwinner,ts-attached: boolean indicating that an actual touchscreen is > >+ attached to the controller > >+ > Brr. While I understand that you were asked to do this, I don't > really see the benefit of another "allwinner" here. As if this > wasn't implied by the "compatible" property.
It's actually the ePAPR that recommends this.
Section 6.1.1, General Principles
"
Some recommended practices includes:
[..]
5. If new properties are needed by the binding, the recommended
format for property names is: “<company>,<property-name>”, where
<company> is an OUI or short unique string like a stock ticker
that identifies the creator of the binding.
"
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
