On Friday, February 21, 2014 6:15 PM, [email protected] wrote: > > From: Dan Carpenter <[email protected]> > Data: Friday, February 21, 2014 4:55 PM > > >To: Dmitry Torokhov > >Cc: Paul Gortmaker; Jingoo Han; Duan Fugang-B38611; Benson Leung; Daniel > >Kurtz; > >[email protected]; [email protected] > >Subject: [patch] Input: remove a duplicative NULL test > > > >"pdata" is non-NULL here. We verified that at the start of the function. > > > >Signed-off-by: Dan Carpenter <[email protected]> > > > >diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c > >b/drivers/input/touchscreen/atmel_mxt_ts.c > >index a70400754e92..40abe90cc924 100644 > >--- a/drivers/input/touchscreen/atmel_mxt_ts.c > >+++ b/drivers/input/touchscreen/atmel_mxt_ts.c > >@@ -1146,7 +1146,7 @@ static int mxt_probe(struct i2c_client *client, > > goto err_free_mem; > > } > > > >- data->is_tp = pdata && pdata->is_tp; > >+ data->is_tp = pdata->is_tp; > > > > input_dev->name = (data->is_tp) ? "Atmel maXTouch Touchpad" : > > "Atmel maXTouch Touchscreen"; > > > Agree, it is redundant. And if you have free time, you can convert the driver > to support devicetree. > > Acked-by: Fugang Duan <[email protected]>
Reviewed-by: Jingoo Han <[email protected]> Best regards, Jingoo Han N떑꿩�r툤y鉉싕b쾊Ф푤v�^�)頻{.n�+돴쪐{콎zn�)�끾�w* jgП� 텎쉸듶줷/곴�z받뻿�2듷솳鈺�&�)傘첺뛴 췍쳺�h��j:+v돣둾�녪
