On Wed, Jul 29, 2015 at 03:07:04PM +0200, Jiri Kosina wrote: > On Tue, 28 Jul 2015, Krzysztof Kozlowski wrote: > > > During unbinding the driver was dereferencing a pointer to memory > > already freed by power_supply_unregister(). > > > > Driver was freeing its internal description of battery through pointers > > stored in power_supply structure. However, because the core owns the > > power supply instance, after calling power_supply_unregister() the > > driver cannot access these members. > > > > Fix this by using resource-managed allocations so internal data will be > > freed by pointers stored in resource-managed core. > > > > Signed-off-by: Krzysztof Kozlowski <[email protected]> > > Reported-by: H.J. Lu <[email protected]> > > Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core") > > Cc: <[email protected]> > > Applied to for-4.2/upstream-fixes, thanks.
Wait, what guarantees do we have that this is only called in probe() paths? Don't we allow hid_hw_start() be deferred to open() calls? In general we need to be careful with devm* conversions in core code. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
