On Wed, Aug 05, 2015 at 11:08:55AM +0100, Stefano Stabellini wrote: > On Tue, 4 Aug 2015, Julien Grall wrote: > > Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN > > is meant, I suspect this is because the first support for Xen was for > > PV. This resulted in some misimplementation of helpers on ARM and > > confused developers about the expected behavior. > > > > For instance, with pfn_to_mfn, we expect to get an MFN based on the name. > > Although, if we look at the implementation on x86, it's returning a GFN. > > > > For clarity and avoid new confusion, replace any reference to mfn with > > gfn in any helpers used by PV drivers. The x86 code will still keep some > > reference of pfn_to_mfn but exclusively for PV (a BUG_ON has been added > > to ensure this). No changes as been made in the hypercall field, even > > though they may be invalid, in order to keep the same as the defintion > > in xen repo. > > > > Take also the opportunity to simplify simple construction such > > as pfn_to_mfn(page_to_pfn(page)) into page_to_gfn. More complex clean up > > will come in follow-up patches. > > > > [1] > > http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb > > > > Signed-off-by: Julien Grall <[email protected]> > > Cc: Stefano Stabellini <[email protected]> > > Cc: Russell King <[email protected]> > > Cc: Konrad Rzeszutek Wilk <[email protected]> > > Cc: Boris Ostrovsky <[email protected]> > > Cc: David Vrabel <[email protected]> > > Cc: Thomas Gleixner <[email protected]> > > Cc: Ingo Molnar <[email protected]> > > Cc: "H. Peter Anvin" <[email protected]> > > Cc: [email protected] > > Cc: "Roger Pau Monné" <[email protected]> > > Cc: Dmitry Torokhov <[email protected]> > > Cc: Ian Campbell <[email protected]> > > Cc: Wei Liu <[email protected]> > > Cc: Juergen Gross <[email protected]> > > Cc: "James E.J. Bottomley" <[email protected]> > > Cc: Greg Kroah-Hartman <[email protected]> > > Cc: Jiri Slaby <[email protected]> > > Cc: Jean-Christophe Plagniol-Villard <[email protected]> > > Cc: Tomi Valkeinen <[email protected]> > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Aside from the x86 bits: > > Reviewed-by: Stefano Stabellini <[email protected]>
Not really important, but just in case anyone waits for my ack on input bits: Acked-by: Dmitry Torokhov <[email protected]> Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
