On Thu, Aug 20, 2015 at 5:37 PM, Dmitry Torokhov <[email protected]> wrote: > Hi Matt, > > On Tue, Aug 18, 2015 at 06:21:29PM -0700, Matt Ranostay wrote: >> >> +static int cap11xx_i2c_remove(struct i2c_client *i2c_client) >> +{ >> + struct cap11xx_priv *priv = i2c_get_clientdata(i2c_client); >> + >> + cap11xx_set_sleep(priv, true); >> + pm_runtime_disable(&i2c_client->dev); >> + pm_runtime_set_suspended(&i2c_client->dev); > > As I mentioned in my previous review:
Ok that makes sense. What would be the correct way to do this with that in mind? > >> This violates ordering: the leds and input device are still open and >> may get requests while you are putting the device to sleep. > > Thanks. > > -- > Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
