Re: [PATCH v3 4/5] tpm_crb: add support for the Arm FF-A start method

[Stuart Yoder]

@@ -119,7 +130,8 @@ static inline bool tpm_crb_has_idle(u32 start_method)
  {
        if ((start_method == ACPI_TPM2_START_METHOD) ||
            (start_method == ACPI_TPM2_COMMAND_BUFFER_WITH_START_METHOD) ||
-           (start_method == ACPI_TPM2_COMMAND_BUFFER_WITH_ARM_SMC))
+           (start_method == ACPI_TPM2_COMMAND_BUFFER_WITH_ARM_SMC) ||
+           (start_method == ACPI_TPM2_CRB_WITH_ARM_FFA))

Now that we have a chance, let's rip of the parentheses clutter.

Will do that throughout.

                return false;
        else
                return true;
@@ -261,6 +273,7 @@ static int crb_cmd_ready(struct tpm_chip *chip)
  static int __crb_request_locality(struct device *dev,
                                  struct crb_priv *priv, int loc)
  {
+       int rc;
        u32 value = CRB_LOC_STATE_LOC_ASSIGNED |
                    CRB_LOC_STATE_TPM_REG_VALID_STS;

Declaration order + put to the same line.

Ack.

Thanks,
Stuart