On Wed, Sep 24, 2025 at 09:29:23AM +0100, Jonathan McDowell wrote: > On Mon, Sep 22, 2025 at 07:43:17PM +0300, Jarkko Sakkinen wrote: > > From: Jarkko Sakkinen <[email protected]> > > > > tpm2_buf_append_auth has only single call site and most of its parameters > > are redundant. Open code it to the call site. Remove illegit FIXME comment > > as there is no categorized bug and replace it with more sane comment about > > implementation (i.e. "non-opionated inline comment"). > > > > Signed-off-by: Jarkko Sakkinen <[email protected]> > > Seems like a reasonable cleanup. > > Reviewed-by: Jonathan McDowell <[email protected]>
Thank you! BTW, I applied your patches to master: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/ I did not yet bother to test them other than compilation and checkpatch but I'm testing this and tpm_buf-series so they will get a lot of stress testing. I'll rebase 'next' once they are actually tested (before PR). BR, Jarkko
