On Sun, 5 Oct 2025 at 08:47, Jarkko Sakkinen <[email protected]> wrote:
>
> and apologies for this late pull request. This pull request disables
> TCG_TPM2_HMAC from the default configuration as it does not perform well
> enough
So having looked more at this, not only does it disable that
TCG_TPM2_HMAC, it does a lot of other things too.
I really am going to require a better pull request, and I have thrown
this one away.
The exclusive access looks debatable to me too. I think you should
also require that the open was done not only with O_EXCL, but as a
write too.
Exclusive reads do not make sense.
Now, I certainly *hope* that nobody has /dev/tmp being world-readable,
so it probably doesn't matter, but that new exclusive access thing is
very different than what the code used to do, and if I read it
correctly it will also disable the kernel doing certain operations. So
it needs to be as limited as possible.
And damn it, it needs to be *explained*. Not have a pull request where
one single line is explained badly.
Linus
