Re: [PATCH] KEYS: fix compilation warnings in the dump_options() function

[yebin]

On 2025/10/28 4:04, Jarkko Sakkinen wrote:

On Fri, Oct 24, 2025 at 02:11:53PM +0800, Ye Bin wrote:

From: Ye Bin <yebi...@huawei.com>

There's issue as follows:
security/keys/trusted-keys/trusted_caam.c: In function ‘dump_options’:
security/keys/trusted-keys/trusted_caam.c:37:20: note: the ABI of passing 
struct with a flexible array member has changed in GCC 4.4
    37 | static inline void dump_options(struct caam_pkey_info pkey_info)
       |                    ^~~~~~~~~~~~

To solve the above problem, pass 'struct caam_pkey_info*' type parameter
to the dump_options() function.

Fixes: 9eb25ca6c973 ("KEYS: trusted: caam based protected key")
Signed-off-by: Ye Bin <yebi...@huawei.com>
---
  security/keys/trusted-keys/trusted_caam.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/security/keys/trusted-keys/trusted_caam.c 
b/security/keys/trusted-keys/trusted_caam.c
index 090099d1b04d..dd7a69bcf6a3 100644
--- a/security/keys/trusted-keys/trusted_caam.c
+++ b/security/keys/trusted-keys/trusted_caam.c
@@ -29,12 +29,12 @@ static const match_table_t key_tokens = {
  };

  #ifdef CAAM_DEBUG
-static inline void dump_options(struct caam_pkey_info pkey_info)
+static inline void dump_options(struct caam_pkey_info *pkey_info)
  {
-       pr_info("key encryption algo %d\n", pkey_info.key_enc_algo);
+       pr_info("key encryption algo %d\n", pkey_info->key_enc_algo);
  }
  #else
-static inline void dump_options(struct caam_pkey_info pkey_info)
+static inline void dump_options(struct caam_pkey_info *pkey_info)
  {
  }
  #endif

Please fix the broken design while at it:

1. Remove the ad-hoc compilation flag (i.e., CAAM_DEBUG).
2. Substitute pr_info calls with pr_debug calls.

Alright, I'll fix the two points you mentioned.

Then you can turn then on and off either dynamically, or alternatively
from the kernel command-line [1].

[1] https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html

BR, Jarkko