Add logging to more easily determine reason for transmit failure

Fixes: 280db21e153d8 ("tpm_tis: Resend command to recover from data transfer 
errors")
Signed-off-by: Jacqueline Wong <[email protected]>
Signed-off-by: Jordan Hand <[email protected]>
---
 drivers/char/tpm/tpm_tis_core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index e2a1769081b1..c79b696086fe 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -471,6 +471,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const 
u8 *buf, size_t len)
                status = tpm_tis_status(chip);
                if (!itpm && (status & TPM_STS_DATA_EXPECT) == 0) {
                        rc = -EIO;
+                       dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be set. 
sts = 0x%08x\n",
+                                       status);
                        goto out_err;
                }
        }
@@ -491,6 +493,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const 
u8 *buf, size_t len)
        status = tpm_tis_status(chip);
        if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) {
                rc = -EIO;
+               dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be unset. sts = 
0x%08x\n",
+                               status);
                goto out_err;
        }
 
-- 
2.53.0.1213.gd9a14994de-goog


Reply via email to