Dag wrote :
>
> > +static int irda_discover_lsap_sel(struct irda_sock *self, char *name)
> 
> Looks OK, but I don't like the name. This function discovers device
> addresses, not lsap selectors. You'll have to query the remote IAS (as the
> comment says) to look up the lsap sel, but this is not what this function
> is doing. It is just checking the discovery log for the device addresses
> stored after receiving XID (eXchange station ID) frames. Should probably be 
> called irda_discover_devices, or irda_do_discovery instead.

        Yes, as you like. I thought it was stupid for each app to
duplicate exactly the same piece of code, but I was not sure if you
would like it (actually, if you just complain about the function name,
I've got a hit !!!).

> -- Dag

        Jean

_______________________________________________
Linux-IrDA mailing list  -  [EMAIL PROTECTED]
http://www4.pasta.cs.UiT.No/mailman/listinfo/linux-irda

Reply via email to