Dag wrote : 
> 
> > +     <-      err = irda_find_lsap_sel(self, addr->sir_name);
> > +     <-      if (err) {
> > +     <-              IRDA_DEBUG(0, __FUNCTION__ "(), connect failed!\n");
> > +     <-              return err;
> > +     <-      }
> 
> Shouldn't the Query of the remote LM-IAS be done in any case? Since your
> discover_lsap_sel() only discovers addresses (and should be renamed) and
> does not query the LM-IAS, then the query will not be done when you don't
> specify the device address!? Have marked my suggestions with <-.

        You are completely wrong. Go to re-read the patch carefully.

        By the way, I reimplemented it a bit cleaner in the assorted
patches for irda10. Have you seen this patch ? It fixes many important
bug. As you seem to read patches in diagonal, I will have to make sure
that you haven't forgotten any of the correct fixes.

> -- Dag

        Jean

_______________________________________________
Linux-IrDA mailing list  -  [EMAIL PROTECTED]
http://www4.pasta.cs.UiT.No/mailman/listinfo/linux-irda

Reply via email to