Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

[John Levon]

Am I right ? against test8pre1

Also, is it a bug to not set TASK_{UN}INTERRUPTIBLE before doing a
schedule_timeout() ? What will happen ?

thanks
john

--- drivers/pcmcia/yenta.c      Fri Aug 11 00:21:32 2000
+++ drivers/pcmcia/yenta.c.new  Fri Sep  1 02:42:55 2000
@@ -574,6 +574,7 @@
                        schedule_timeout(HZ);
                remove_wait_queue(&socket->wait, &wait);
        } while (!signal_pending(current));
+       set_current_state(TASK_RUNNING);
        MOD_DEC_USE_COUNT;
        return 0;
 }
--- drivers/usb/storage/transport.c     Wed Aug 30 18:46:53 2000
+++ drivers/usb/storage/transport.c.new Fri Sep  1 03:14:07 2000
@@ -419,6 +419,7 @@
                up(&(us->current_urb_sem));
                remove_wait_queue(&wqh, &wait);
                kfree(dr);
+               set_current_state(TASK_RUNNING);
                return status;
        }
 
@@ -472,6 +473,7 @@
                /* something went wrong */
                up(&(us->current_urb_sem));
                remove_wait_queue(&wqh, &wait);
+               set_current_state(TASK_RUNNING);
                return status;
        }
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/