In article <[EMAIL PROTECTED]> you wrote:
> Here's a brace of small patches that ought to be OK for 2.2.18.
> adTHANKSvance for consideration
> 3. Trivial patch to fs/vfat/namei.c to avoid a compile-time warning.
> Index: linux/fs/vfat/namei.c
> --- linux/fs/vfat/namei.c:1.2 Fri Sep 1 19:03:16 2000
> +++ linux/fs/vfat/namei.c Thu Sep 28 00:53:55 2000
> @@ -676,7 +676,8 @@
> i += 4;
> } else {
> int llen;
> - nls->char2uni(ip, &llen, op, op+1);
> + nls->char2uni((unsigned char *)ip,
> + &llen, op, op+1);
> op += 2;
> ip += llen;
> i += llen;
Note that this is properly fixed in pre15 by making char2uni's first
argument "const char *" instead of "char *"; casting it as you did only
hides a (currently non existing but potential) bug where an NLS function
might modify the original.....
Greetings,
Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
