Thomas, On Tue, 20 Oct 2015 21:23:29 +0200 (CEST), Thomas Gleixner wrote: > On Tue, 20 Oct 2015, Thomas Petazzoni wrote: > > As discussed on IRC, another simpler (code line wise) solution is to > > simply clear the IRQ_NOAUTOEN flag in the irq-armada-370-xp, which > > brings us back to what set_irq_flags() was doing, without actually > > reverting Rob's patch. > > I prefer that for 4.3.
Done, I've proposed a patch as a reply to this e-mail. It's a one-liner. > > However, relying on IRQ_NOAUTOEN being cleared doesn't seem like the > > right long term solution, which is why I implemented what I believe is > > a (hopefully) better long term solution. > > Agreed. > > I'll go over the proposed solution tomorrow afternoon (I'm > traveling/conferencing...) Sure, no problem. I also noticed that MSI interrupts are not properly re-enabled after resume, but it's not a regression from 4.2, as I can also reproduce the issue on 4.2, so I'll handle that separately. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/