Hi Soren, > -----Original Message----- > From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] > Sent: Thursday, October 22, 2015 10:03 PM > To: Appana Durga Kedareswara Rao > Cc: Anirudha Sarangi; w...@grandegger.com; m...@pengutronix.de; Michal > Simek; Appana Durga Kedareswara Rao; linux-...@vger.kernel.org; > net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 2/2] can: xilinx: fix bug in bus error handling > > On Thu, 2015-10-22 at 10:16AM +0530, Kedareswara rao Appana wrote: > > Simply resetting the peripheral on bus off condition is not enough, > > Because we also need to re-initialize the whole device. > > This patch fixes this issue. > > > > Signed-off-by: Kedareswara rao Appana <appa...@xilinx.com> > > --- > > drivers/net/can/xilinx_can.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/can/xilinx_can.c > > b/drivers/net/can/xilinx_can.c index 055d6f3..9aeb85f 100644 > > --- a/drivers/net/can/xilinx_can.c > > +++ b/drivers/net/can/xilinx_can.c > > @@ -529,6 +529,8 @@ static int xcan_rx(struct net_device *ndev) > > return 1; > > } > > > > +static void xcan_chip_stop(struct net_device *ndev); > > Isn't it possible to move the function and avoid the forward declaration?
Yes it is possible to move the function will fix it in the next version of the patch. Regards, Kedar. > > Sören
