On Fri, Oct 23, 2015 at 3:48 PM, Christoph Hellwig <h...@lst.de> wrote: > Hi Daniel, > > all these functions look great, but can you also move your new > iio_sw_trigger_type_configfs_register/unregister functions to the > core code as those are the wrappers that everyone would have to write, > e.g. something like: > > int configfs_register_default_group(struct config_group *parent_group, > const char *name, struct config_item_type *item_type) > { > struct config_group *group; > > group = kzalloc(sizeof(*group), GFP_KERNEL); > if (!group) > return -ENOMEM; > config_group_init_type_name(group, name, item_type); > > ret = configfs_register_group(parent_group, group); > if (ret) > kfree(group); > return ret; > } > > and the same on the unregister side? Yes, this is a good idea. Will do! > > With that: > > Reviewed-by: Christoph Hellwig <h...@lst.de>
thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/