On Wed, Oct 21, 2015 at 5:30 AM, Rasmus Villemoes <[email protected]> wrote: > BUG is a completely unnecessarily big hammer, and we're more likely to > get the internal bug reported if we just pr_err() and ensure the test > suite fails. > > Cc: Kees Cook <[email protected]> > Signed-off-by: Rasmus Villemoes <[email protected]>
Acked-by: Kees Cook <[email protected]> -Kees > --- > lib/test_printf.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index c5a666af9ba5..9232a2add28c 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -91,7 +91,12 @@ __test(const char *expect, int elen, const char *fmt, ...) > int rand; > char *p; > > - BUG_ON(elen >= BUF_SIZE); > + if (elen >= BUF_SIZE) { > + pr_err("error in test suite: expected output length %d too > long. Format was '%s'.\n", > + elen, fmt); > + failed_tests++; > + return; > + } > > va_start(ap, fmt); > > -- > 2.6.1 > -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
