On Sun, 3 Dec 2006, Alan wrote:
> > if (!p) {
> > - p = kmalloc(sizeof(*p), GFP_KERNEL);
> > + p = kzalloc(sizeof(*p), GFP_KERNEL);
> > if (!p)
> > return -ENOMEM;
> > file->private_data = p;
> > }
> > - memset(p, 0, sizeof(*p));
> > mutex_init(&p->lock);
> > p->op = op;
>
>
> NAK
>
> If p was already set (ie private data existed) the old code zeroed it,
> your code does not, but only zeroes the new stuff.
whoops, sorry, my bad.
rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
