Hi Saurabh, On 10/27/2015 03:46 AM, Saurabh Sengar wrote: > use UPIO_MEM rather then SERIAL_IO_MEM. > both have the same value > > Signed-off-by: Saurabh Sengar <[email protected]> > --- > drivers/tty/serial/sa1100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/sa1100.c b/drivers/tty/serial/sa1100.c > index fd3d132..283c7e0 100644 > --- a/drivers/tty/serial/sa1100.c > +++ b/drivers/tty/serial/sa1100.c > @@ -579,7 +579,7 @@ sa1100_verify_port(struct uart_port *port, struct > serial_struct *ser) > ret = -EINVAL; > if (sport->port.irq != ser->irq) > ret = -EINVAL; > - if (ser->io_type != SERIAL_IO_MEM) > + if (ser->io_type != UPIO_MEM)
SERIAL_IO_* io_type defines are the appropriate constants for the struct serial_struct::io_type field. Both are defined in the uapi header, include/uapi/linux/serial.h UPIO_* io_type defines are the appropriate constants for the struct uart_port::io_type field. Both are defined in the kernel header, include/kernel/serial_core.h I defined the UPIO_* io_types in terms of SERIAL_IO_* because userspace breakage was occurring as contributors were changing the UPIO_* constant values. Regards, Peter Hurley > ret = -EINVAL; > if (sport->port.uartclk / 16 != ser->baud_base) > ret = -EINVAL; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
