On Thu, Oct 29, 2015 at 07:12:01AM +0100, Marion & Christophe JAILLET wrote: > > > Le 27/10/2015 11:27, Jarkko Sakkinen a écrit : > >On Fri, Oct 23, 2015 at 10:37:33AM +0300, Jarkko Sakkinen wrote: > >>On Thu, Oct 22, 2015 at 10:32:41PM +0200, Christophe JAILLET wrote: > >>>Reference to the 'np' node is dropped before dereferencing the 'sizep' and > >>>'basep' pointers, which could by then point to junk if the node has been > >>>freed. > >>> > >>>Refactor code to call 'of_node_pup' later. > >>> > >>>Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> > >>LGTM. > >Is there anyone able to provide Tested-by for this? > > > >Christophe, were you able to reproduce the crash (insmod/rmmod couple > >of times maybe?) and validate that it was gone after fixing the bug? > > Hi, > no, I never triggered the bug. > This is just something noticed while looking at potential issues related to > incorrect use of 'of_node_pup'. > I only compile tested the patch.
The fix is so obvious that I see no reason not to include it. Thanks for the good work. > Best regards, > CJ /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
