On Thu, Oct 29, 2015 at 05:23:08PM -0500, Bjorn Helgaas wrote: >From: Alexander Duyck <[email protected]> > >If virtfn_add() fails, we call virtfn_remove() for any previously added >devices. Remove the devices in reverse order (first-added is >last-removed), which is more natural and doesn't require an additional >variable. > >[bhelgaas: changelog, split to separate patch for reviewability] >Signed-off-by: Alexander Duyck <[email protected]> >Signed-off-by: Bjorn Helgaas <[email protected]>
Interesting. Reviewed-by: Wei Yang <[email protected]> >--- > drivers/pci/iov.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c >index ca400a9..c86d94c 100644 >--- a/drivers/pci/iov.c >+++ b/drivers/pci/iov.c >@@ -233,7 +233,7 @@ int __weak pcibios_sriov_enable(struct pci_dev *pdev, u16 >num_vfs) > static int sriov_enable(struct pci_dev *dev, int nr_virtfn) > { > int rc; >- int i, j; >+ int i; > int nres; > u16 initial; > struct resource *res; >@@ -328,8 +328,8 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn) > return 0; > > failed: >- for (j = 0; j < i; j++) >- virtfn_remove(dev, j, 0); >+ while (i--) >+ virtfn_remove(dev, i, 0); > > iov->ctrl &= ~(PCI_SRIOV_CTRL_VFE | PCI_SRIOV_CTRL_MSE); > pci_cfg_access_lock(dev); -- Richard Yang Help you, Help me -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
