On Mon, Dec 04, 2006 at 02:26:52PM -0700, Eric W. Biederman wrote: > Greg KH <[EMAIL PROTECTED]> writes: > > > On Mon, Dec 04, 2006 at 12:18:30PM -0800, Lu, Yinghai wrote: > >> -----Original Message----- > >> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > >> > >> >arch/x86_64/kernel/early_printk.c | 574 > >> +++++++++++++++++++++++++++++++++++++ > >> > drivers/usb/host/ehci.h | 8 + > >> > include/asm-x86_64/fixmap.h | 1 > >> > >> Can you separate usbdebug handle out from early_printk? > > > > Yeah, at least tear it out of x86-64, so those of us stuck on different > > platforms can use this :) > > > > Other than that minor issue, this looks great. I don't have a x86-64 > > box set up here at the moment, so I can't test it, but it looks > > acceptable at first glance. > > Makes sense. I'm curious now what architecture do you have?
i386 My main development box these days is a mac mini due to it's great form factor and ability to suspend to ram easily. Unfortunately they don't come with a working 64bit processor just yet. > Anyway next time I touch this the project will be how to integrate > this into the kernel cleanly. This round was to figure out how > to get some working code. > > If someone beats me to the punch on generalizing this code I won't > mind. > > The first pass was a success. And the performance is reasonable > assuming you don't plug the end you are watching into a usb1 only > port. > > Given that I didn't really know anything about usb a week ago I think > I did pretty well :) Yes, you certainly did, no complaint from me at all about that :) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/