All of the magic numbers pertain to register CTRL1. document all the values in CTRL1 with defines from the datasheet
Signed-off-by: Joshua Clayton <[email protected]> --- drivers/rtc/rtc-pcf2123.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index 3acb2c8..257ce7d 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -234,7 +234,7 @@ static int pcf2123_rtc_set_time(struct device *dev, struct rtc_time *tm) tm->tm_mday, tm->tm_mon, tm->tm_year, tm->tm_wday); /* Stop the counter first */ - ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, 0x20); + ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, CTRL1_STOP); if (ret < 0) return ret; @@ -253,7 +253,7 @@ static int pcf2123_rtc_set_time(struct device *dev, struct rtc_time *tm) return ret; /* Start the counter */ - ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, 0x00); + ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, CTRL1_CLEAR); if (ret < 0) return ret; @@ -280,13 +280,13 @@ static int pcf2123_probe(struct spi_device *spi) /* Send a software reset command */ dev_dbg(&spi->dev, "resetting RTC\n"); - ret = pcf2123_write_reg(&spi->dev, PCF2123_REG_CTRL1, 0x58); + ret = pcf2123_write_reg(&spi->dev, PCF2123_REG_CTRL1, CTRL1_SW_RESET); if (ret < 0) goto kfree_exit; /* Stop the counter */ dev_dbg(&spi->dev, "stopping RTC\n"); - ret = pcf2123_write_reg(&spi->dev, PCF2123_REG_CTRL1, 0x20); + ret = pcf2123_write_reg(&spi->dev, PCF2123_REG_CTRL1, CTRL1_STOP); if (ret < 0) goto kfree_exit; @@ -298,7 +298,7 @@ static int pcf2123_probe(struct spi_device *spi) if (ret < 0) goto kfree_exit; - if (!(rxbuf[0] & 0x20)) { + if (!(rxbuf[0] & CTRL1_STOP)) { dev_err(&spi->dev, "chip not found\n"); ret = -ENODEV; goto kfree_exit; @@ -309,7 +309,7 @@ static int pcf2123_probe(struct spi_device *spi) (spi->max_speed_hz + 500) / 1000); /* Start the counter */ - ret = pcf2123_write_reg(&spi->dev, PCF2123_REG_CTRL1, 0x00); + ret = pcf2123_write_reg(&spi->dev, PCF2123_REG_CTRL1, CTRL1_CLEAR); if (ret < 0) goto kfree_exit; -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
