On Fri, Nov 6, 2015 at 4:49 PM, Olliver Schinagl <o.schin...@ultimaker.com> wrote: > Hey Thierry, > > but why have the bit macro at all then :)
For my opinion, it's good to use in new code, or when you have this change as a continuation of bigger series. Though, others might have a different one :-) > > But that choice I guess I leave to you, as it's your section, I know some > submaintainers prefer it and want it to be used, so I guess it's something > in general kernel wide that should be desided on, BIT() macro preferred or > not. > > Olliver > > > On 06-11-15 15:46, Thierry Reding wrote: >> >> On Mon, Oct 26, 2015 at 10:32:35PM +0100, Olliver Schinagl wrote: >>> >>> From: Olliver Schinagl <oli...@schinagl.nl> >>> >>> The pwm header defines bits manually while there is a nice bitops.h with >>> a BIT() macro. Use the BIT() macro to set bits in pwm.h >>> >>> Signed-off-by: Olliver Schinagl <oli...@schinagl.nl> >>> --- >>> include/linux/pwm.h | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> I don't think this is a useful change. The BIT() macro needs the same >> number of characters to type at the expense of requiring an additional >> include. >> >> Thierry > > > -- > Met vriendelijke groeten, Kind regards, 与亲切的问候 > > Olliver Schinagl > Software Engineer > Research & Development > Ultimaker B.V. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
