On Wed, 6 Dec 2006, David Howells wrote:
>
> + if (get_wq_data(work) == cwq
> + && test_bit(WORK_STRUCT_PENDING, &work->management)
>
> I wonder if those can be combined, perhaps:
Gcc should do it for us, afaik. I didn't check, but gcc is generally
pretty good at combining logical operations like this, because it's very
common.
> Otherwise for i386 the compiler can't combine them because test_bit() is done
> with inline asm.
Nope. Look again.
test_bit() with a constant number is done very much in C, and very much on
purpose. _Exactly_ to allow the compiler to combine these kinds of things.
> And:
>
> + if (!test_bit(WORK_STRUCT_PENDING, &work->management))
>
> Should possibly be:
>
> + if (!work_pending(work))
Yeah, that's a worthy cleanup.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
